Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: capture response from raw_call #5

Merged
merged 6 commits into from
Apr 14, 2023
Merged

fix: capture response from raw_call #5

merged 6 commits into from
Apr 14, 2023

Conversation

failingtwice
Copy link
Contributor

capturing response to keep the compiler from what acting out,
For details, see https://docs.vyperlang.org/en/stable/built-in-functions.html#raw_call

TheDZhon
TheDZhon approved these changes Apr 13, 2023
View reviewed changes
Copy link

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Let's hold this trump card for a while 😀

TheDZhon
TheDZhon requested changes Apr 14, 2023
View reviewed changes
Copy link

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I suggest to polish up the explanations

tests/test_gate_seal.py Outdated Show resolved Hide resolved
contracts/GateSeal.vy Show resolved Hide resolved
tests/test_gate_seal.py Outdated Show resolved Hide resolved
tests/test_gate_seal.py Outdated Show resolved Hide resolved
TheDZhon
TheDZhon approved these changes Apr 14, 2023
View reviewed changes
Copy link

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 👍

@failingtwice failingtwice merged commit 399666c into main Apr 14, 2023
@failingtwice failingtwice deleted the raw-call-response branch April 14, 2023 11:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@failingtwice @TheDZhon